-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce importmap and stimulus #15422
Draft
hellcp-work
wants to merge
7
commits into
openSUSE:master
Choose a base branch
from
hellcp-work:stimulus
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellcp-work
force-pushed
the
stimulus
branch
2 times, most recently
from
December 27, 2023 10:27
77d8951
to
6ec5054
Compare
This also fixes an issue with multiple of the copy to clipboard components on a single page, where it would always grab the first input instead of the closest one
hellcp-work
force-pushed
the
stimulus
branch
from
December 27, 2023 10:30
6ec5054
to
d6f7858
Compare
hellcp-work
force-pushed
the
stimulus
branch
from
December 27, 2023 10:36
d6f7858
to
552816e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #15422 +/- ##
==========================================
- Coverage 86.23% 86.23% -0.01%
==========================================
Files 788 788
Lines 25790 25791 +1
==========================================
Hits 22240 22240
- Misses 3550 3551 +1 |
hellcp-work
force-pushed
the
stimulus
branch
from
December 28, 2023 12:16
4b366cc
to
de225c6
Compare
hellcp-work
force-pushed
the
stimulus
branch
from
December 28, 2023 12:40
de225c6
to
e6091ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sibling to #15201, either one of them can be merged at any point, but they are related
Stimulus is a part of Hotwire