Add importmaps rails and turbo rails #15201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krauselukas
added
Frontend
|
Would it be possible to go further, so that we can test if we can include action cable with turbo. That way we could use the full functionality of it? |
Maybe, I dont want to make the scope of the PR to big. I have to fix the obs-server rpm first. |
https://github.com/rails/importmap-rails Import maps let us import Javascript without the need of Webpack or similar. This is one step towards a more modern Javascript stack in our project and required in order to use Turbo Rails.
The installation script of importmap rails wasn't able to add the tag since we use the haml format in our views (it was looking for .erb). The tag will include the javascript coming from importmaps-rails in our views.
It interfers with some of our current javascript code, for now we should opt-in on demand.
As an example of what we can do with turbo rails, I'm using it for the inline editing of the project information. After adapting the user and package inline editing as well, we can remove some javascript code.
krauselukas
force-pushed
the
hackweek/add_importmap_rails_and_turbo
branch
from
9c50fd1 to
9fd2279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: I would like to test this on our test instance first, to see if it works in production environment.
https://github.com/rails/importmap-rails
https://github.com/hotwired/turbo-rails
Import maps let us import Javascript modules without the need of Webpack
or similar. This is one step towards a more modern Javascript stack
in our project and required in order to use Turbo Rails.
Turbo gives you the speed of a single-page web application without having to write any JavaScript. Turbo accelerates links and form submissions without requiring you to change your server-side generated HTML.
As an example, I included a little refactoring in the PR, that moves the inline editing of the project information from using Javascript to Turbo.
TODO: