[WIP] setup.py: Transition to scikit-build #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
topic-skikit-build
branch
from
22312e2 to
779db7e
Compare
ax3l
changed the title
ax3l
force-pushed
the
topic-skikit-build
branch
from
779db7e to
60ed7ca
Compare
ax3l
force-pushed
the
topic-skikit-build
branch
3 times, most recently
from
eb68045 to
d3cc4e4
Compare
|
This pull request introduces 3 alerts when merging d3cc4e4 into 23d1e1a - view on LGTM.com new alerts:
|
Use scikit-build instead of vanilla low-level setuptools for building. This should enable us shipping generated binaries.
|
This pull request introduces 3 alerts when merging c637066 into 23d1e1a - view on LGTM.com new alerts:
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use scikit-build instead of vanilla low-level setuptools for building. This should enable us shipping generated binaries #574.
To Do
python setup.py sdist) is still clean and functional when build deps are pre-installed (doc!)pip wheel -v .works and is functionalverify(use pip or build these days)python setup.py bdist_wheelworks when build deps are pre-installed (doc!)Dockerfilewheeldistribution works and is functionalbin/tools work