Repair: RPath-Contained Library not Found

[ax3l]

Hi,

I am building a python module with a dependent shared lib via scikit-build, which results in an in-wheel file structure like this:

/data/lib/python3.8/site-packages/my-module-1.2.3-cp38-cp38-linux_x86_64.so
/data/lib/libdependency.so

I properly set the RPATH of my-module-1.2.3-cp38-cp38-linux_x86_64.so to $ORIGIN/../...
Nevertheless, auditwheel repair reports the already contained library as missing:

$ auditwheel repair --plat manylinux2010_x86_64 my-module-1.2.3-cp38-cp38-linux_x86_64.whl
ValueError: Cannot repair wheel, because required library "libdependency.so" could not be located

I attached an example wheel of openPMD-api that can be used to demonstrate the problem (build recipe: openPMD/openPMD-api#585):
openPMD_api-0.12.0.dev0-cp38-cp38-linux_x86_64.whl.zip

In order to fix this issue, I could imagine that somewhere around here in get_wheel_elfdata we should filter the needed_libs for libs found in the RPATH (and runpath?).

Ref.: scikit-build/scikit-build#69 (comment)

[ax3l]

Argh, I did forget to set the rpath for a newly shipped executable...
$ORIGIN/../lib:$ORIGIN/../...

So things are already filtered well by rpath, nice! :)

Suggestion: Sorting the output by "the following external libraries could not be located for ELF " could make it a bit simpler to debug the output.

Too bad, I already started a patch ;)

diff --git a/auditwheel/wheel_abi.py b/auditwheel/wheel_abi.py
index 69f83ce..a46226f 100644
--- a/auditwheel/wheel_abi.py
+++ b/auditwheel/wheel_abi.py
@@ -104,12 +104,20 @@ def get_wheel_elfdata(wheel_fn: str):
                 ) % '\n\t'.join(shared_libraries_in_purelib)
             )
 
+        # check if a lib is found in a list of RPATHs
+        def lib_in_rpaths(lib, rpaths):
+            for rpath in rpaths:
+                if os.path.isfile(os.path.join(rpath, basename(lib))):
+                    return True
+            return False
+
         # Get a list of all external libraries needed by ELFs in the wheel.
+        # print([x['needed'] for x in nonpy_elftree.values()])
         needed_libs = {
             lib
             for elf in itertools.chain(full_elftree.values(),
                                        nonpy_elftree.values())
-            for lib in elf['needed']
+            for lib in elf['needed'] if not lib_in_rpaths(lib, elf['rpath'])
         }
 
         for fn in nonpy_elftree.keys():