refactor(feature:checker-inbox-task): migrate to CMP#2389
Merged
niyajali merged 5 commits intoopenMF:kmp-implfrom Jun 5, 2025
Merged
refactor(feature:checker-inbox-task): migrate to CMP#2389niyajali merged 5 commits intoopenMF:kmp-implfrom
niyajali merged 5 commits intoopenMF:kmp-implfrom
Conversation
biplab1
force-pushed
the
MIFOSAC-416-checker-inbox-task-cmp-migration
branch
from
87e3cf6 to
3130a98
Compare
biplab1
force-pushed
the
MIFOSAC-416-checker-inbox-task-cmp-migration
branch
from
9f900f2 to
b8d7beb
Compare
revanthkumarJ
suggested changes
Jun 3, 2025
cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/HomeDestinationsScreen.kt
Show resolved
Hide resolved
...system/src/commonMain/kotlin/com/mifos/core/designsystem/component/MifosTextFieldDropdown.kt
Show resolved
Hide resolved
feature/auth/src/commonMain/kotlin/com/mifos/feature/auth/login/LoginViewModel.kt
Show resolved
Hide resolved
revanthkumarJ
approved these changes
Jun 3, 2025
...system/src/commonMain/kotlin/com/mifos/core/designsystem/component/MifosTextFieldDropdown.kt
Outdated
Show resolved
Hide resolved
.../domain/src/commonMain/kotlin/com/mifos/core/domain/useCases/GetCheckerInboxBadgesUseCase.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
After MifosTextFieldDropdown update: After_MifosTextFieldDropdown_update.mp4After combined error handling update: Loading_sweet_error.mp4 |
.../domain/src/commonMain/kotlin/com/mifos/core/domain/useCases/GetCheckerInboxBadgesUseCase.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@niyajali I have made the changes as requested by reviewers. Can you take a final look and let me know if anything else is required? If everything looks good kindly merge. |
Contributor
Author
|
After the unauthorised error was fixed (#2397): checker_inbox_screens_after_401_fix.mp4 |
.../domain/src/commonMain/kotlin/com/mifos/core/domain/useCases/GetCheckerInboxBadgesUseCase.kt
Show resolved
Hide resolved
HekmatullahAmin
approved these changes
Jun 5, 2025
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#416
feature_checker_inbox_screen.mp4
feature_checker_inbox_all_screens.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
[ X] Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anything[ X] If you have multiple commits please combine them into one commit by squashing them.