feat : Collection sheet migrated to cmp#2396
Merged
niyajali merged 19 commits intoopenMF:kmp-implfrom Jun 9, 2025
Merged
Conversation
biplab1
reviewed
Jun 4, 2025
...s/feature/individualCollectionSheet/generateCollectionSheet/GenerateCollectionSheetScreen.kt
Outdated
Show resolved
Hide resolved
...alCollectionSheet/individualCollectionSheetDetails/IndividualCollectionSheetDetailsScreen.kt
Outdated
Show resolved
Hide resolved
itsPronay
reviewed
Jun 4, 2025
...n/kotlin/com/mifos/feature/individualCollectionSheet/navigation/CollectionSheetNavigation.kt
Show resolved
Hide resolved
# Conflicts: # cmp-android/dependencies/demoDebugRuntimeClasspath.txt # cmp-android/dependencies/demoReleaseRuntimeClasspath.txt # cmp-android/dependencies/prodDebugRuntimeClasspath.txt # cmp-android/dependencies/prodReleaseRuntimeClasspath.txt # cmp-navigation/src/commonMain/kotlin/cmp/navigation/di/KoinModules.kt # cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/FeatureNavHost.kt
Collaborator
|
@revanthkumarJ is it done? |
Collaborator
|
@revanthkumarJ There is a duplicate PR opened by Arjun, and ask team members for approval |
Contributor
Author
|
@niyajali the pr opened by arjun is a duplicate one as he is not avaialble and having some git issues he asked me to open a new pr regarding this pr i have implemented the screens which are working in development branch other features are not working in development branch so i just migrated them but unable to check them |
Collaborator
|
@revanthkumarJ resolve merge conflicts and ask team members for approval |
# Conflicts: # cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/FeatureNavHost.kt
revanthkumarJ
force-pushed
the
collection-sheet
branch
from
1249cb5 to
8bd9fac
Compare
biplab1
reviewed
Jun 8, 2025
...ividualCollectionSheet/newIndividualCollectionSheet/NewIndividualCollectionSheetViewModel.kt
Outdated
Show resolved
Hide resolved
...ividualCollectionSheet/newIndividualCollectionSheet/NewIndividualCollectionSheetViewModel.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/mifos/feature/individualCollectionSheet/paymentDetails/PaymentDetailsViewModel.kt
Show resolved
Hide resolved
...idualCollectionSheet/savedIndividualCollectionSheet/SavedIndividualCollectionSheetCompose.kt
Outdated
Show resolved
Hide resolved
Contributor
|
@revanthkumarJ Other than the ImageLoaderUtils issue, everything else looks good to me. Although the feature isn’t fully functional yet, as we discussed, it can be merged for now. I have requested some changes — once those are done, I will approve. |
Contributor
Author
|
@biplab1 done the changes |
biplab1
approved these changes
Jun 9, 2025
Contributor
Author
|
@niyajali can you do final review and merge this |
niyajali
approved these changes
Jun 9, 2025
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#418