Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a cumulative "interpretation" of Unknown metrics #69

Closed
dashpole opened this issue Jan 31, 2022 · 4 comments · Fixed by open-telemetry/opentelemetry-collector-contrib#32605

Comments

@dashpole
Copy link

Prometheus Unknown metrics are metrics that have no type information, such as metrics from a third party system. Prometheus doesn't actually make use of type information, so Prometheus users can treat Unknown metrics as either counters or gauges at query time.

Under the current proposed specification, open-telemetry/opentelemetry-specification#2266, OpenTelemetry will convert Unknown-typed metrics to OTLP Gauges. While this is arguably more useful than dropping metrics, it does not preserve the fact that the metric type was initially unknown, and may make it difficult in some backends for users to treat them as counters.

If possible, we should attempt to preserve the fact that these metrics were initially Unknown-typed.

@dashpole
Copy link
Author

dashpole commented Feb 2, 2022

One idea presented by @Aneurysm9 at the prometheus-wg meeting today is to add a resource metric attribute as a way to indicate that the metric was original unknown as a convention. This would not require data model changes.

@Aneurysm9
Copy link
Member

Not a resource attribute, but a metric attribute since the attribute would not necessarily apply to all metrics from that resource.

@damemi
Copy link

damemi commented Jun 15, 2023

reviving this topic, is there any opposition to a proposal for how to address this? I am willing to put something together for the spec

@dashpole
Copy link
Author

dashpole commented Oct 9, 2024

@dashpole dashpole closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants