Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider supporting additional OpenMetrics types to the datamodel #2409

Closed
dashpole opened this issue Mar 8, 2022 · 0 comments · Fixed by #3868
Closed

Consider supporting additional OpenMetrics types to the datamodel #2409

dashpole opened this issue Mar 8, 2022 · 0 comments · Fixed by #3868
Assignees
@yurishkuro
Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory

Comments

@dashpole
Copy link
Contributor

dashpole commented Mar 8, 2022

What are you trying to achieve?

There are a few OpenMetrics types which are currently round-tripped from OM -> OTel -> OM to different types:

  • Info
    • Round-tripps to OM Gauge
  • StateSet
    • Round-tripps to OM Gauge
  • Unknown
    • Round-tripps to OM Gauge

One option to consider is to add types to our datamodel explicitly.

Another option is to add a metric attribute which identifies the original type (open-telemetry/wg-prometheus#69 (comment)).

Additional context.

Suggested in #2380 (review).

@bogdandrutu @Aneurysm9
@dashpole dashpole added the spec:metrics Related to the specification/metrics directory label Mar 8, 2022
@dashpole dashpole mentioned this issue Mar 8, 2022
Merged
@reyang reyang added the area:data-model For issues related to data model label Mar 11, 2022
@jmacd jmacd mentioned this issue Oct 4, 2022
Merged
@dashpole dashpole mentioned this issue Oct 25, 2023
Open
@dashpole dashpole mentioned this issue Feb 8, 2024
Merged
5 tasks
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@dashpole
Prometheus compatibility: represent Prometheus Info, StateSet and Unk…
77eed44 
…nown-typed metrics in OTLP (open-telemetry#3868)

Fixes
open-telemetry#3058
Fixes
open-telemetry#1712
Fixes
open-telemetry#2409

## Changes

Use metric.metadata (added in
open-telemetry/opentelemetry-proto#514) to
support representing prometheus metric types in OTLP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurishkuro yurishkuro

Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
3 participants
@dashpole @yurishkuro @reyang