-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve unknown, info, and stateset metric types from prometheus receivers to exporters #32605
Merged
djaglowski
merged 10 commits into
open-telemetry:main
from
dashpole:prometheus_type_metadata
May 2, 2024
Merged
Preserve unknown, info, and stateset metric types from prometheus receivers to exporters #32605
djaglowski
merged 10 commits into
open-telemetry:main
from
dashpole:prometheus_type_metadata
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
exporter/prometheus
pkg/translator/prometheus
receiver/prometheus
Prometheus receiver
labels
Apr 22, 2024
dashpole
changed the title
Preserve unknown, info, and StateSet metric types from prometheus receivers to exporters
Preserve unknown, info, and stateset metric types from prometheus receivers to exporters
Apr 22, 2024
dashpole
force-pushed
the
prometheus_type_metadata
branch
from
April 23, 2024 17:44
7bda1c7
to
705dcae
Compare
Aneurysm9
approved these changes
Apr 24, 2024
dashpole
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Apr 25, 2024
aknuds1
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
exporter/prometheus
pkg/translator/prometheus
ready to merge
Code review completed; ready to merge by maintainers
receiver/prometheus
Prometheus receiver
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Preserve the original prometheus metric type using metric.metadata, as described in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#metric-metadata
From https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#gauges-1
Link to tracking Issue:
Fixes #16768
Fixes open-telemetry/prometheus-interoperability-spec#69
Testing:
Updated unit tests.
Note
The prometheus exporter uses the prometheus client library, which does not support info or stateset metric types, so the prometheus exporter only preserves
unknown
-typed metrics.