[.github/CODEOWNERS] Add semconv container/k8s approvers #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
mx-psi
approved these changes
Nov 13, 2023
arminru
approved these changes
Nov 13, 2023
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
AlexanderWert
approved these changes
Nov 14, 2023
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
…try#510) Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com> Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To cover #427
Adds container semantic conventions approvers for:
container.resource attributesoci.resource attributesAdds k8s semantic conventions approvers for:
k8s.resource attributesNOTE: Registry files for k8s do not exist at the moment but will be added with https://github.com/open-telemetry/semantic-conventions/pull/506/files, so let's include them already.