Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to create semconv-{container,k8s}-approvers #427

Closed
ChrsMark opened this issue Oct 19, 2023 · 16 comments
Closed

Request to create semconv-{container,k8s}-approvers #427

ChrsMark opened this issue Oct 19, 2023 · 16 comments
Assignees

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Oct 19, 2023

I'd like to request creating 2 new approvers groups semconv-container-approvers and semconv-k8s-approvers (as per suggestion at #427 (comment)) that would be responsible for reviewing and maintaining semantic conventions related to the containers' and kubernetess areas respectively.

Folks proposed for that groups / interested:

semconv-container-approvers:

semconv-k8s-approvers:

Related PRs and issues:

@ChrsMark
Copy link
Member Author

@dmitryax could you also ping people from the Collector's side that would be interested to join?

@mlunadia would you be interested into joining as well?

@TylerHelmuth
Copy link
Member

I am interested in joining. I would also like to nominate @jinja2 who has been a tremendous source of Kubernetes knowledge for the Collector components.

@ChrsMark
Copy link
Member Author

Awesome @TylerHelmuth , I have added you both :)!

@dmitryax
Copy link
Member

Thank you, @ChrsMark!

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Oct 24, 2023

Additional related issue: #430

@jsuereth
Copy link
Contributor

jsuereth commented Nov 1, 2023

I think this is a little to broad of a scope. E.g. are you going to be owning every semconv for technology coming from CNCF, including otel itself?

Let's alter the name to denote some limits, e.g.

  • semconv-container-approvers: All things container related (not just docker)
  • semconv-k8s-approvers: All things kubernetes related (but not nomad, e.g.)

I think it makes sense for us to keep the two lists separate even if it's the same set of folks initially.

@ChrsMark
Copy link
Member Author

ChrsMark commented Nov 1, 2023

Thank's @jsuereth , that makes sense! I can split the group into 2 different groups then.

@ChrsMark ChrsMark changed the title Request to create semconv-cloud-native-approvers Request to create semconv-container/k8s-approvers Nov 1, 2023
@ChrsMark ChrsMark changed the title Request to create semconv-container/k8s-approvers Request to create semconv-{container,k8s}-approvers Nov 1, 2023
@dashpole
Copy link
Contributor

dashpole commented Nov 1, 2023

I'd like to nominate myself for the k8s-approvers group.

@mlunadia
Copy link
Contributor

mlunadia commented Nov 2, 2023

@ChrsMark yes, please add me in

@arminru
Copy link
Member

arminru commented Nov 13, 2023

I created @open-telemetry/semconv-container-approvers and added the following members:

@mlunadia I was not able to add you as you are not a member of the OpenTelemetry organization yet.
Please review the requirements and application steps described here: https://github.com/open-telemetry/community/blob/main/community-membership.md#member

@arminru
Copy link
Member

arminru commented Nov 13, 2023

I created @open-telemetry/semconv-k8s-approvers and added the following members:

@mlunadia please see my comment above.

@arminru
Copy link
Member

arminru commented Nov 13, 2023

@open-telemetry/semconv-container-approvers and @open-telemetry/semconv-k8s-approvers you can go ahead and update https://github.com/open-telemetry/semantic-conventions/blob/main/.github/CODEOWNERS to add OWNERS for the relevant subdirectories.

@ChrsMark
Copy link
Member Author

Thank's @arminru. I have filed #510 to add the CODEOWNERS.

@mlunadia
Copy link
Contributor

@arminru I have now my membership and have requested to join. Thanks!

@mlunadia
Copy link
Contributor

@arminru just checking if you can add me to the approvers for both of these groups.
TIA

@arminru
Copy link
Member

arminru commented Feb 12, 2024

Hi @mlunadia!
After the initial bootstrapping of a newly founded group, approvers are expected to satisfy the approver requirements laid out here: https://github.com/open-telemetry/community/blob/main/community-membership.md#approver
Please open an issue if all of these apply so we can add you to the group.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants