Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client.address sampling relevant on HTTP server spans #469

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Make client.address sampling relevant on HTTP server spans #469

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4598fdc
Make client.address and client.port sampling relevant on HTTP server …
trask Oct 29, 2023
57b9a07
only client.address
trask Oct 29, 2023
ff8f538
Merge branch 'main' into make-client-address-sampling-relevant
AlexanderWert Oct 30, 2023
6738fd8
Merge branch 'main' into make-client-address-sampling-relevant
trask Oct 30, 2023
e3a416f
Merge branch 'main' into make-client-address-sampling-relevant
AlexanderWert Oct 31, 2023
fb3f647
Merge branch 'main' into make-client-address-sampling-relevant
AlexanderWert Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into make-client-address-sampling-relevant
  • Loading branch information
@AlexanderWert
AlexanderWert authored Oct 31, 2023
commit e3a416ff3882e1d00287772103c74ef1e1426957
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ release.
([#460](https://github.com/open-telemetry/semantic-conventions/pull/460))
- Clarify that `client.port` is the port of whichever client was captured in `client.address`.
([#471](https://github.com/open-telemetry/semantic-conventions/pull/471))
- Change `client.port` from recommended to opt-in on HTTP server spans
([#472](https://github.com/open-telemetry/semantic-conventions/pull/472))
- Make `client.address` sampling relevant on HTTP server spans.
([#469](https://github.com/open-telemetry/semantic-conventions/pull/469))

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.