Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client.address sampling relevant on HTTP server spans #469

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ release.
- BREAKING: Make `url.scheme` opt_in for HTTP client and remove default value for
`server.port` making it required on the client.
([#459](https://github.com/open-telemetry/semantic-conventions/pull/459))
- Make `client.address` sampling relevant on HTTP server spans.
([#469](https://github.com/open-telemetry/semantic-conventions/pull/469))

### Features

Expand Down
1 change: 1 addition & 0 deletions docs/http/http-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin

Following attributes MUST be provided **at span creation time** (when provided at all), so they can be considered for sampling decisions:

* [`client.address`](../general/attributes.md)
* [`server.address`](../general/attributes.md)
* [`server.port`](../general/attributes.md)
* [`url.path`](../attributes-registry/url.md)
Expand Down
1 change: 1 addition & 0 deletions model/trace/http.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ groups:
requirement_level: opt_in
brief: Local socket port. Useful in case of a multi-port host.
- ref: client.address
sampling_relevant: true
lmolkova marked this conversation as resolved.
Show resolved Hide resolved
note: >
The IP address of the original client behind all proxies, if
known (e.g. from [Forwarded#for](https://developer.mozilla.org/docs/Web/HTTP/Headers/Forwarded#for),
Expand Down
Loading