Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] After a fix:* command, tell user to rerun full checks #5122

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 29, 2024

/cc @cartermp @svrnm

@chalin chalin added the CI/infra CI & infrastructure label Aug 29, 2024
@chalin chalin requested a review from a team August 29, 2024 15:48
@chalin
Copy link
Contributor Author

chalin commented Aug 29, 2024

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10618411382

@chalin
Copy link
Contributor Author

chalin commented Aug 29, 2024

I don't know if running a fix:* command over this PR will use the script in the PR (I'm thinking that it won't), but it's worth a try.

@chalin
Copy link
Contributor Author

chalin commented Aug 29, 2024

It doesn't seem like it. So we might just have to merge this PR and test it afterwards.

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@chalin chalin merged commit 470a5f8 into open-telemetry:main Aug 29, 2024
17 checks passed
@chalin chalin deleted the chalin-im-tell-to-run-checks-2024-08-29 branch August 29, 2024 21:15
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants