Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Repeated PRs by registry auto-update script can cause problems #5123

Open
chalin opened this issue Aug 29, 2024 · 1 comment
Open

[CI] Repeated PRs by registry auto-update script can cause problems #5123

chalin opened this issue Aug 29, 2024 · 1 comment
Assignees
Labels
CI/infra CI & infrastructure

Comments

@chalin
Copy link
Contributor

chalin commented Aug 29, 2024

For context see #5119 (comment).

In summary,

The auto-update script issues a new PR:

Unbeknownst to Phil, he ran a fix command, and got a green light from GH to merge, so he merged; but that broken link checking. I've followed up with

but I'm opening this issue / discussion to explore if there is a way to "pause" the registry auto-update to avoid a similar problem? If there is a (relatively easy) way, then the question is: do we want to use such a pause feature. Note that the OTel package version update script will not reissue a new PR. I know that the situation is different here, but if we could have a similar behavior: don't issue a new registry auto-update PR if there is one that is already open?

@chalin chalin added the CI/infra CI & infrastructure label Aug 29, 2024
@chalin chalin changed the title [CI] Registry auto-update script issue of repeated PRs [CI] Repeated PRs by registry auto-update script can cause problems Aug 29, 2024
@svrnm
Copy link
Member

svrnm commented Sep 4, 2024

Dependabot and Renovate do it in a way that they check for existing PRs and update them accordingly (or close them and open new ones). I did it the way it is right now, because it was just "the easy solution". Let me see if and how this can be improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: No status
Development

No branches or pull requests

2 participants