Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/rust example hyper v1 #4242

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ekquasar
Copy link
Contributor

@ekquasar ekquasar commented Apr 3, 2024

Supersedes PR#4236

Summary

The HTTP crate hyper has had a major version update (from 0.14 to 1.x; more details at https://hyper.rs/guides/1/upgrading/).

In this PR, I've updated the roll_dice Rust example to use the new major version.

Moreover, the opentelemetry packaging has changed (esp. the refractor of the sdk from the core opentelemetry base crate into its own opentelemetry_sdk). I've updated the example accordingly.

@ekquasar ekquasar requested review from a team April 3, 2024 12:47
Copy link

linux-foundation-easycla bot commented Apr 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@hdost
Copy link
Contributor

hdost commented Apr 3, 2024

I would wait until open-telemetry/opentelemetry-rust#1427 is resolved.

@svrnm
Copy link
Member

svrnm commented Apr 8, 2024

I would wait until open-telemetry/opentelemetry-rust#1427 is resolved.

I blocked the issue, please update us when we can unblock it

@ekquasar
Copy link
Contributor Author

I'm sorry, @hdost , I read that -http thread and it's not clear to me why it's beneficial to wait until other packages update to hyper 1.0? Is it just that e.g. a new dev would follow the example (e.g. this updated one) with hyper 1.x and then try to use the -http exporter which would then barf?

@svrnm
Copy link
Member

svrnm commented May 2, 2024

@hdost @ekquasar any updates?

@ekquasar
Copy link
Contributor Author

ekquasar commented May 2, 2024

The desire appears to be to "step across the line together" with other projects. I wouldn't advocate that approach, but I understand there may be good reasons to do so.

@theletterf
Copy link
Member

Still blocked?

@ekquasar
Copy link
Contributor Author

It's a community question, perhaps for the maintainers, not a technical one; to my understanding.

@svrnm
Copy link
Member

svrnm commented Jul 11, 2024

@open-telemetry/rust-approvers is there anything we can do for this PR?

@svrnm
Copy link
Member

svrnm commented Aug 1, 2024

@open-telemetry/rust-approvers following up, anything we can do for this PR? Close it or instructions for @ekquasar how to get this merged?

@svrnm
Copy link
Member

svrnm commented Sep 24, 2024

@open-telemetry/rust-approvers can you take a look, if we can unblock this PR now? open-telemetry/opentelemetry-rust#1427 is closed now, so please check once again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Need SIG Review
Development

Successfully merging this pull request may close these issues.

4 participants