-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/rust example hyper v1 #4242
base: main
Are you sure you want to change the base?
Conversation
…crate to use the opentelemetry_sdk;
48781c8
to
e3cc6e4
Compare
I would wait until open-telemetry/opentelemetry-rust#1427 is resolved. |
I blocked the issue, please update us when we can unblock it |
I'm sorry, @hdost , I read that -http thread and it's not clear to me why it's beneficial to wait until other packages update to hyper 1.0? Is it just that e.g. a new dev would follow the example (e.g. this updated one) with hyper 1.x and then try to use the -http exporter which would then barf? |
The desire appears to be to "step across the line together" with other projects. I wouldn't advocate that approach, but I understand there may be good reasons to do so. |
Still blocked? |
It's a community question, perhaps for the maintainers, not a technical one; to my understanding. |
@open-telemetry/rust-approvers is there anything we can do for this PR? |
@open-telemetry/rust-approvers following up, anything we can do for this PR? Close it or instructions for @ekquasar how to get this merged? |
@open-telemetry/rust-approvers can you take a look, if we can unblock this PR now? open-telemetry/opentelemetry-rust#1427 is closed now, so please check once again |
Supersedes PR#4236
Summary
The HTTP crate hyper has had a major version update (from 0.14 to 1.x; more details at https://hyper.rs/guides/1/upgrading/).
In this PR, I've updated the roll_dice Rust example to use the new major version.
Moreover, the opentelemetry packaging has changed (esp. the refractor of the sdk from the core opentelemetry base crate into its own opentelemetry_sdk). I've updated the example accordingly.