Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/rust example hyper v1 #4236

Closed

Conversation

ekquasar
Copy link
Contributor

@ekquasar ekquasar commented Apr 2, 2024

Summary

The HTTP crate hyper has had a major version update (from 0.14 to 1.x; more details at https://hyper.rs/guides/1/upgrading/).

In this PR, I've updated the roll_dice Rust example to use the new major version.

Moreover, the opentelemetry packaging has changed (esp. the refractor of the sdk from the core opentelemetry base crate into its own opentelemetry_sdk). I've updated the example accordingly.

@ekquasar ekquasar requested review from a team April 2, 2024 13:17
Copy link

linux-foundation-easycla bot commented Apr 2, 2024

CLA Missing ID CLA Not Signed

@ekquasar ekquasar force-pushed the update/rust-example-hyper-v1 branch from a21d8c7 to 211e8ce Compare April 2, 2024 13:32
@ekquasar
Copy link
Contributor Author

ekquasar commented Apr 2, 2024

🙃 I've tried to fix the commit authorship, signed the EasyCLA, but still ❌

@cartermp
Copy link
Contributor

cartermp commented Apr 3, 2024

Ergh, sorry for the CLA shenanigans :(

Some possible things to try:

  1. Sign into the cla tool with the email from the original commit, see if it lets you sign that way
  2. ...maybe rebasing works? never tried
  3. Close and re-open a new PR using your @ekquasar email for commits

@ekquasar
Copy link
Contributor Author

ekquasar commented Apr 3, 2024

@cartermp thank you - the new PR is #4242
^ EasyCLA passing, linter is not... but that I can certainly figure out.

@ekquasar ekquasar closed this Apr 3, 2024
@ekquasar ekquasar deleted the update/rust-example-hyper-v1 branch April 3, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants