Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec compliance matrix for C++ (metrics instrument names) #3703

Merged

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Sep 21, 2023

Changes

Updated the following entry in the spec compliance matrix:

  • Section Metrics, item "Instrument names conform to the specified syntax."
  • Language C++

The lastest spec changes (#3648, #3422) are implemented by the following PR:

so C++ can be marked compliant with the specification.

For non-trivial changes, follow the change proposal process.

@marcalff marcalff requested review from a team September 21, 2023 19:28
@marcalff
Copy link
Member Author

cc @open-telemetry/cpp-maintainers

@carlosalberto
Copy link
Contributor

Enough reviews from C++ approvers, merging.

@carlosalberto carlosalberto merged commit 5f9bc69 into open-telemetry:main Sep 22, 2023
6 checks passed
@marcalff marcalff deleted the spec_compliance_metric_cpp branch September 22, 2023 20:04
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…n-telemetry#3703)

## Changes

Updated the following entry in the spec compliance matrix:

* Section Metrics, item "Instrument names conform to the specified
syntax."
* Language C++

The lastest spec changes (open-telemetry#3648, open-telemetry#3422) are implemented by the following
PR:

* open-telemetry/opentelemetry-cpp#2281
* open-telemetry/opentelemetry-cpp#2303

so C++ can be marked compliant with the specification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants