Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Allow metric instrument names to contain / characters #2303

Closed
marcalff opened this issue Sep 8, 2023 · 2 comments · Fixed by #2310
Closed

[SDK] Allow metric instrument names to contain / characters #2303

marcalff opened this issue Sep 8, 2023 · 2 comments · Fixed by #2310
Assignees
@marcalff
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

marcalff commented Sep 8, 2023

Once the following spec change is merged:

adjust the SDK to accept metric names with the new rules.
@marcalff marcalff added bug Something isn't working issue:blocked Fix blocked, waiting for other fixes as prerequisites labels Sep 8, 2023
@marcalff marcalff self-assigned this Sep 8, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 8, 2023
@lalitb
Copy link
Member

lalitb commented Sep 11, 2023 •
edited
Loading

nit - should it have a bug label?

@ThomsonTan
Copy link
Contributor

nit - should it have a bug label?

Probably better to apply the spec-compliance label?

@marcalff marcalff removed issue:blocked Fix blocked, waiting for other fixes as prerequisites needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 11, 2023
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Sep 14, 2023
@marcalff
Fixes open-telemetry#2303
df88178
@marcalff marcalff mentioned this issue Sep 14, 2023
Merged
3 tasks
@marcalff marcalff mentioned this issue Sep 21, 2023
Merged
5 tasks
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this issue Sep 22, 2023
@marcalff
Update spec compliance matrix for C++ (metrics instrument names) (#3703)
5f9bc69 
## Changes

Updated the following entry in the spec compliance matrix:

* Section Metrics, item "Instrument names conform to the specified
syntax."
* Language C++

The lastest spec changes (#3648, #3422) are implemented by the following
PR:

* open-telemetry/opentelemetry-cpp#2281
* open-telemetry/opentelemetry-cpp#2303

so C++ can be marked compliant with the specification.
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@marcalff
Update spec compliance matrix for C++ (metrics instrument names) (ope…
64b04b9 
…n-telemetry#3703)

## Changes

Updated the following entry in the spec compliance matrix:

* Section Metrics, item "Instrument names conform to the specified
syntax."
* Language C++

The lastest spec changes (open-telemetry#3648, open-telemetry#3422) are implemented by the following
PR:

* open-telemetry/opentelemetry-cpp#2281
* open-telemetry/opentelemetry-cpp#2303

so C++ can be marked compliant with the specification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK] Allow metric instrument names to contain / characters marcalff/opentelemetry-cpp
3 participants
@ThomsonTan @lalitb @marcalff