Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove content from pages which have been moved #3667

Closed
wants to merge 7 commits into from

Conversation

trask
Copy link
Member

@trask trask commented Aug 18, 2023

to avoid mistakes like this #3663 (comment)

@trask trask marked this pull request as ready for review August 18, 2023 01:54
@trask trask requested review from a team August 18, 2023 01:54
@trask
Copy link
Member Author

trask commented Aug 21, 2023

Looks like there's a lot of references from the spec to the semconv pages, is it ok to just update these to point to the semconv repo? or is the spec repo supposed to avoid links to semconv repo?

bookmark-not-found ./specification/performance-benchmark.md(20,3): Cannot find bookmark '#service' in 'specification/resource/semantic_conventions/README.md'.
bookmark-not-found ./specification/compatibility/prometheus_and_openmetrics.md(399,1): Cannot find bookmark '#service' in 'specification/resource/semantic_conventions/README.md'.
bookmark-not-found ./specification/resource/sdk.md(34,1): Cannot find bookmark '#semantic-attributes-with-sdk-provided-default-value' in 'specification/resource/semantic_conventions/README.md'.
bookmark-not-found ./specification/configuration/sdk-environment-variables.md(80,146): Cannot find bookmark '#semantic-attributes-with-sdk-provided-default-value' in 'specification/resource/semantic_conventions/README.md'.
bookmark-not-found ./specification/configuration/sdk-environment-variables.md(81,52): Cannot find bookmark '#service' in 'specification/resource/semantic_conventions/README.md'.
bookmark-not-found ./specification/compatibility/opentracing.md(139,1): Cannot find bookmark '#opentracing' in 'specification/trace/semantic_conventions/compatibility.md'.
bookmark-not-found ./specification/protocol/exporter.md(175,162): Cannot find bookmark '#telemetry-sdk' in 'specification/resource/semantic_conventions/README.md'.
bookmark-not-found ./specification/common/attribute-naming.md(68,3): Cannot find bookmark '#pluralization' in 'specification/metrics/semantic_conventions/README.md'.
bookmark-not-found ./specification/logs/data-model.md(463,1): Cannot find bookmark '#attributes' in 'specification/logs/semantic_conventions/exceptions.md'.
bookmark-not-found ./supplementary-guidelines/compatibility/aws.md(41,10): Cannot find bookmark '#sqs-event' in 'specification/trace/semantic_conventions/instrumentation/aws-lambda.md'.
bookmark-not-found ./specification/trace/sdk_exporters/jaeger.md(60,8): Cannot find bookmark '#service' in 'specification/resource/semantic_conventions/README.md'.
bookmark-not-found ./specification/trace/sdk_exporters/zipkin.md(100,17): Cannot find bookmark '#general-remote-service-attributes' in 'specification/trace/semantic_conventions/span-general.md'.
bookmark-not-found ./specification/trace/sdk_exporters/zipkin.md(101,19): Cannot find bookmark '#server-and-client-attributes' in 'specification/trace/semantic_conventions/span-general.md'.
bookmark-not-found ./specification/trace/sdk_exporters/zipkin.md(102,25): Cannot find bookmark '#server-and-client-attributes' in 'specification/trace/semantic_conventions/span-general.md'.
bookmark-not-found ./specification/trace/sdk_exporters/zipkin.md(103,47): Cannot find bookmark '#server-and-client-attributes' in 'specification/trace/semantic_conventions/span-general.md'.
bookmark-not-found ./specification/glossary.md(120,1): Cannot find bookmark '#telemetry-sdk' in 'specification/resource/semantic_conventions/README.md'.
bookmark-not-found ./spec-compliance-matrix.md(244,3): Cannot find bookmark '#semantic-attributes-with-sdk-provided-default-value' in 'specification/resource/semantic_conventions/README.md'.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 29, 2023
@carlosalberto
Copy link
Contributor

is it ok to just update these to point to the semconv repo? or is the spec repo supposed to avoid links to semconv repo?

I think that's totally fine (cc @chalin @open-telemetry/specs-semconv-approvers please confirm)

@MrAlias MrAlias removed the Stale label Aug 30, 2023
@joaopgrassi
Copy link
Member

It seems we missed this one under /common when initially adding the move notice:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/url.md

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Later we might consider support auto-page redirect as was mentioned earlier, and possibly a change in wording (e.g., "This page has moved to ...").

@carlosalberto
Copy link
Contributor

@trask So yes, we can point to the spec repo directly. Once that is done, we can merge this PR ;)

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 14, 2023
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Sep 27, 2023
@arminru arminru reopened this Sep 27, 2023
@trask
Copy link
Member Author

trask commented Oct 2, 2023

Closing in favor of #3711 (thanks @jsuereth!)

@trask trask closed this Oct 2, 2023
@trask trask deleted the remove-content branch October 2, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.