Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove local stubs of semantic conventions. #3711

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Remove local stubs of semantic conventions. #3711

merged 3 commits into from
Oct 3, 2023

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Oct 2, 2023

  • Remove semantic convention stubs
  • Update all links to point at new repo.
  • Update CODEOWNERS for new areas of responsibility for semconv approvers

Note: There's a few things that need to updated as part of further cleanup.

Replaces #3667

@jsuereth jsuereth requested review from a team October 2, 2023 20:10
@trask trask mentioned this pull request Oct 2, 2023
Closed
arminru
arminru approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @chalin - to make sure we don't break the website with this 🙂

@arminru arminru requested a review from chalin October 3, 2023 11:57
@carlosalberto
Copy link
Contributor

Thanks! So much needed!

@reyang reyang added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Oct 3, 2023
@reyang reyang merged commit 89f9bf3 into open-telemetry:main Oct 3, 2023
7 checks passed
@reyang
Copy link
Member

reyang commented Oct 3, 2023

cc @chalin - to make sure we don't break the website with this 🙂

@chalin FYI to avoid running into reciprocating merge conflicts, I merged the PR as editorial changes. If there is anything we need to fix, we can quickly do it in follow up PRs.

@jsuereth jsuereth deleted the pr-remove-semconv-stubs branch October 3, 2023 18:50
@martinkuba martinkuba mentioned this pull request Oct 3, 2023
Merged
@laurit laurit mentioned this pull request Oct 4, 2023
Merged
@hovavza hovavza mentioned this pull request Oct 14, 2023
Merged
@chalin
Copy link
Contributor

chalin commented Nov 2, 2023

Looking into potential breakages on the website side of things now.

@chalin
Copy link
Contributor

chalin commented Nov 2, 2023

Oh, this is in v1.26.0! So all is good! ✨

@jack-berg jack-berg mentioned this pull request Nov 7, 2023
Merged
@IgorKhramtsov IgorKhramtsov mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@arminru arminru arminru approved these changes

@pyohannes pyohannes pyohannes approved these changes

@reyang reyang reyang approved these changes

@chalin chalin Awaiting requested review from chalin

Assignees

@bogdandrutu bogdandrutu

Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jsuereth @carlosalberto @reyang @chalin @trask @arminru @pyohannes @bogdandrutu