-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update semantic conventions to distinguish between int and double #1550
Merged
arminru
merged 6 commits into
open-telemetry:main
from
dynatrace-oss-contrib:semconv-number-int
Mar 18, 2021
Merged
Update semantic conventions to distinguish between int and double #1550
arminru
merged 6 commits into
open-telemetry:main
from
dynatrace-oss-contrib:semconv-number-int
Mar 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was recently introduced in open-telemetry/build-tools#30. Fixes open-telemetry#1096.
@anuraaga With this change you will be able to resolve #1422 (comment) since v0.3.0 allows you to define it as |
carlosalberto
approved these changes
Mar 16, 2021
jsuereth
approved these changes
Mar 16, 2021
bogdandrutu
approved these changes
Mar 16, 2021
MrAlias
reviewed
Mar 16, 2021
MrAlias
approved these changes
Mar 17, 2021
anuraaga
approved these changes
Mar 18, 2021
ThomsonTan
pushed a commit
to ThomsonTan/opentelemetry-specification
that referenced
this pull request
Mar 30, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This distinction was recently introduced in https://github.com/open-telemetry/build-tools/releases/tag/v0.3.0.
Note that the generic
number
type was dropped.Fixes #1096.