Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update semantic constants generator template #3042

Closed
arminru opened this issue Mar 18, 2021 · 4 comments · Fixed by #3047
Closed

Update semantic constants generator template #3042

arminru opened this issue Mar 18, 2021 · 4 comments · Fixed by #3047
Assignees
@arminru

Comments

@arminru
Copy link
Member

arminru commented Mar 18, 2021

The template for generating constants for semantic conventions needs to be updated to work with the latest version of the YAML format and generator tool (https://github.com/open-telemetry/build-tools/releases/tag/v0.3.0) in order to update the spec reference to the next release (after open-telemetry/opentelemetry-specification#1550).
@jkwatson
Copy link
Contributor

This can be done the next time the spec gets released and we re-gen the semconv module code. 👍

@arminru arminru self-assigned this Mar 19, 2021
arminru added a commit to dynatrace-oss-contrib/opentelemetry-java that referenced this issue Mar 19, 2021
@arminru
Update semantic convention constants generator script and template
8cc1215 
Fixes open-telemetry#3042.
@arminru
Copy link
Member Author

arminru commented Mar 19, 2021

Pending on the fix open-telemetry/build-tools#36 to be merged and released as v0.3.1.

@arminru arminru mentioned this issue Mar 19, 2021
Merged
@Oberon00
Copy link
Member

Oberon00 commented Apr 9, 2021

Another update that will be necessary: Replace the unique("fqn") filter by checking for is_local and not ref, like here: https://github.com/open-telemetry/opentelemetry-js/pull/2083/files#diff-30b86e034e5acba0b0c9f36baaffc11d373cd389966d609d067deb00bd7dfdf7R30, see open-telemetry/build-tools#41

arminru added a commit to dynatrace-oss-contrib/opentelemetry-java that referenced this issue Apr 9, 2021
@arminru
Update semantic convention constants generator script and template
2086c49 
The template was updated to reflect the changes introduced in otel/semconvgen v0.3.0 and v0.3.1.
The script was updated to pin the version of the otel/semconvgen image, otherwise incompatible updates would break it.

Fixes open-telemetry#3042.
@arminru
Copy link
Member Author

arminru commented Apr 9, 2021

Another update that will be necessary: Replace the unique("fqn") filter by checking for is_local and not ref, like here: open-telemetry/opentelemetry-js#2083 (files), see open-telemetry/build-tools#41

Done in adcf6ef.

arminru added a commit to dynatrace-oss-contrib/opentelemetry-java that referenced this issue Apr 15, 2021
@arminru
Update semantic convention constants generator script, template and s…
d6dabf6 
…pec reference

The template was updated to reflect the changes introduced in otel/semconvgen v0.3.0 and v0.3.1.
The script was updated to pin the version of the otel/semconvgen image, otherwise incompatible updates would break it.

Fixes open-telemetry#3042.
jkwatson pushed a commit that referenced this issue Apr 19, 2021
@arminru
Update semantic convention constants generator script and template (#…
c28d17a 
…3047)

* Update semantic convention constants generator script, template and spec reference

The template was updated to reflect the changes introduced in otel/semconvgen v0.3.0 and v0.3.1.
The script was updated to pin the version of the otel/semconvgen image, otherwise incompatible updates would break it.

Fixes #3042.

* ./generate.sh

* Update template according to open-telemetry/build-tools#41

* ./generate.sh

The template was updated to use the correct base definitions, so the Javadoc for some attributes changed (the ones for `rpc.*`, for example).
This also changed the ordering but it is still reproducible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arminru arminru

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Oberon00 @jkwatson @arminru