Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracer resolution default #171

Closed
carlosalberto opened this issue Jul 3, 2019 · 3 comments
Closed

Tracer resolution default #171

carlosalberto opened this issue Jul 3, 2019 · 3 comments
Labels
area:api Cross language API specification issue
Milestone

Comments

@carlosalberto
Copy link
Contributor

Currently the spec defines this as:

Tracer provider is an internal class used by the global registry (OpenTelemetry) to get a tracer instance. The global registry delegates calls to the provider every time a tracer instance is requested. This is necessary for use-cases when a single instrumentation code runs for multiple deployments.

But there's no actual mention on what should be loaded if there's no explicitly defined Tracing component - should it try to no-op one (API only), or should it try the actual SDK? (My feeling is that the former should be the one)

This came up in OpenTelemetry in Python (open-telemetry/opentelemetry-python#29).

@z1c0
Copy link
Contributor

z1c0 commented Jul 9, 2019

Having the no-op tracer as default seems like the most reasonable approach.
Trying to load the actual SDK would either mean tight coupling of API and SDK or having to rely on reflection, dynamic loading, ...

@jmacd
Copy link
Contributor

jmacd commented Dec 4, 2019

See also open-telemetry/oteps#45

@tedsuo
Copy link
Contributor

tedsuo commented Dec 4, 2019

Decision: observability APIs are write only, so a default implementation will be a No-op.

When context propagation becomes a separate layer, it may have a default implementation. open-telemetry/oteps#66

@tedsuo tedsuo closed this as completed Dec 4, 2019
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 21, 2024
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 23, 2024
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Cross language API specification issue
Projects
None yet
Development

No branches or pull requests

6 participants