Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load opentelemetry-sdk impl by default #165

Closed
c24t opened this issue Sep 24, 2019 · 2 comments
Closed

Load opentelemetry-sdk impl by default #165

c24t opened this issue Sep 24, 2019 · 2 comments
Labels
api Affects the API package. metrics tracing

Comments

@c24t
Copy link
Member

c24t commented Sep 24, 2019

From #160 (comment).

cc @Oberon00.

Consider loading the default implementations of Tracer and Meter if opentelemetry-sdk is installed instead of requiring the user to call set_preferred_{tracer,meter}_implementation. Right now users get the API (aka no-op) implementation by default, even if the "default" implementation is available.

@Oberon00
Copy link
Member

We explicitly decided against that. The code was already there and was removed. If you want to change that again, there is a spec-level issue: open-telemetry/opentelemetry-specification#171 (CC @carlosalberto)

@c24t
Copy link
Member Author

c24t commented Sep 27, 2019

You're right! After some discussion I agree that we shouldn't automatically load the "default" implementation, but we should make it easy to do so with some global config. We'll just continue to have ugly examples for the SDK for now.

@c24t c24t closed this as completed Sep 27, 2019
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
closes open-telemetry#165

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the API package. metrics tracing
Projects
None yet
Development

No branches or pull requests

2 participants