Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-events): add data property to events api #114

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented May 19, 2023

Closes #113
Unblocks #108

Changes

  • Adds data property to Event interface that should be used by instrumentation. attributes should only be used to provide additional attributes

Questions

Do we also need to update the emit function here? There was some discussion about making that function take arguments instead of one argument that is the Event interface.

Copy link
Collaborator

@martinkuba martinkuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with merging this for now so that we can unblock other work. But we should update to the LogAttributes type once it is brought over here (it is already available in the core JS repo - open-telemetry/opentelemetry-js#3821).

@martinkuba martinkuba merged commit d2acd49 into open-telemetry:auto-instrumentation-poc Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants