Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Web Vitals Autoinstrumentation #108

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented May 10, 2023

No description provided.

@shumone
Copy link

shumone commented May 17, 2023

Hi @pkanal, do you have a timeline on this package? We're looking to incorporate the web-vitals library in otel as well and wanted to know whether we should pick it up in parallel, as we'll need it in the near future.

Also, for the CLS (and FID) metric, are we planning on keeping the default implementations for them? I know that they're dependent on user interactions, and so might never get sent until very late in the webpage's lifespan. Just wanted to know if there was any discussion on this edge case.

@pkanal
Copy link
Contributor Author

pkanal commented May 19, 2023

Hi @pkanal, do you have a timeline on this package? We're looking to incorporate the web-vitals library in otel as well and wanted to know whether we should pick it up in parallel, as we'll need it in the near future.

Also, for the CLS (and FID) metric, are we planning on keeping the default implementations for them? I know that they're dependent on user interactions, and so might never get sent until very late in the webpage's lifespan. Just wanted to know if there was any discussion on this edge case.

@shumone There's no specific timeline but I am actively working on this. The plan with the OTel Client Side SIG is to create a proof of concept in this sandbox repo and once we're happy with the API here, we will contribute this to the opentelemetry-js-contrib repo. If you're planning on working on this, we'd definitely be happy to collaborate!

At the moment we're planning on keeping the default implementation for CLS and FID. If you have any feedback for how to handle them differently feel free to comment on the PR for how they could be handled!

@Abinet18 Abinet18 force-pushed the purvi/web-vitals-autoinstrumentation branch from c53b34f to ebed67b Compare September 11, 2023 21:30
@pkanal pkanal force-pushed the purvi/web-vitals-autoinstrumentation branch from f53a76a to c45f0aa Compare October 3, 2023 15:55
@Abinet18 Abinet18 force-pushed the purvi/web-vitals-autoinstrumentation branch from 7dba1f0 to 4ed5d6b Compare October 6, 2023 20:03
@martinkuba martinkuba marked this pull request as ready for review October 17, 2023 20:25
@martinkuba martinkuba merged commit 62f8681 into open-telemetry:auto-instrumentation-poc Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants