-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Run all benchmarks in one action #2885
perf: Run all benchmarks in one action #2885
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2885 +/- ##
=======================================
- Coverage 81.1% 81.1% -0.1%
=======================================
Files 124 124
Lines 23927 23927
=======================================
- Hits 19411 19406 -5
- Misses 4516 4521 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This'll make it easier to use a jazzier benchmark process (e.g., to publish to pages, like otel collector does) as well. No brainer to approve once we've seen it run through successfully once and checked that we've got the same set of benches running. |
Same time and same number of benchmarks (168). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
straight to prod
|
Changes
Runs all the benchmarks in one single action. It also removes all feature flags from the github action and relies on the features defined in the
Cargo.toml
files. This ensure that no benchmarks are skipped accidentally.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes