Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Nit fix to benchmarks #2884

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

cijothomas
Copy link
Member

Some test were not run in benchmarks-CI due to missing feature flag.
Also did a nit cleanup - benchmarks didn't need rt-tokio so its cleaned up.

@cijothomas cijothomas requested a review from a team as a code owner March 28, 2025 18:15
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.1%. Comparing base (303803e) to head (549075d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2884   +/-   ##
=====================================
  Coverage   81.1%   81.1%           
=====================================
  Files        124     124           
  Lines      23927   23927           
=====================================
  Hits       19410   19410           
  Misses      4517    4517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas closed this Mar 28, 2025
@cijothomas cijothomas reopened this Mar 28, 2025
@cijothomas cijothomas merged commit 99cb67d into open-telemetry:main Mar 28, 2025
24 checks passed
@bantonsson
Copy link
Contributor

I've done a more future proof fix for missing feature flags in #2885

@cijothomas
Copy link
Member Author

I've done a more future proof fix for missing feature flags in #2885

❤️ Thanks!

@cijothomas cijothomas deleted the cijothomas/nit-bench-fix branch March 31, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants