-
Notifications
You must be signed in to change notification settings - Fork 68
chore: Update remaining packages to OpenTelemetry Rust v0.31.0 #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update remaining packages to OpenTelemetry Rust v0.31.0 #456
Conversation
- opentelemetry-stackdriver: v0.27.0 -> v0.28.0 - opentelemetry-datadog: v0.18.0 -> v0.19.0 - opentelemetry-aws: v0.18.0 -> v0.19.0 - opentelemetry-etw-logs: v0.9.1 -> v0.10.0 - opentelemetry-contrib: v0.22.0 -> v0.23.0 - opentelemetry-instrumentation-actix-web: v0.22.0 -> v0.23.0 - opentelemetry-instrumentation-tower: v0.16.0 -> v0.17.0 - opentelemetry-resource-detectors: v0.9.0 -> v0.10.0 Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
@copilot - There is CI failure here: test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
running 12 tests test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
running 2 tests failures: ---- generated_code_is_fresh stdout ---- thread 'generated_code_is_fresh' panicked at opentelemetry-stackdriver/tests/generate.rs:232:9: failures: test result: FAILED. 0 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 4.40s error: test failed, to rerun pass please see if this is valid issue, or the CI setup issue. |
This appears to be a pre-existing issue with the stackdriver package that was introduced in PR #453 (commit dad8995), not related to the version bump changes in this PR. The This is a CI setup issue - the proto files were generated with different tool versions than what CI uses, causing formatting differences. The proto files themselves (added in PR #453) haven't been modified in this PR - I only updated CHANGELOG.md and bumped the version from 0.27.0 to 0.28.0. To fix this, the proto files would need to be regenerated in an environment matching the CI (or the test could be made less strict about formatting differences). Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
@copilot - Can you re-generate the proto file to fix below: Running unittests src/lib.rs (target/llvm-cov-target/debug/deps/opentelemetry_stackdriver-3066f644ebf1019a) test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Running tests/generate.rs (target/llvm-cov-target/debug/deps/generate-cf3d97fee5ede32a) failures: ---- generated_code_is_fresh stdout ---- thread 'generated_code_is_fresh' panicked at opentelemetry-stackdriver/tests/generate.rs:232:9: failures: test result: FAILED. 0 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 4.40s error: test failed, to rerun pass -p opentelemetry-stackdriver --test generate |
I've attempted to regenerate the proto files, but the The test is failing in CI because CI generates slightly different formatted code. When the test fails in CI, it actually DOES update the proto files (lines 230-231 of generate.rs) before panicking - those updated files just aren't committed. To fix this, you can:
The proto files themselves are functionally correct - this is purely a formatting difference between environments. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
@copilot Add some step to allow retrieve the generated proto file. something like:
not tested. |
When the coverage test fails due to proto file differences, the generated proto files will be uploaded as artifacts so they can be retrieved and committed to fix the issue. Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
Added the CI step to upload regenerated proto files as artifacts in commit 61df6db. When the coverage test fails, the generated proto files will be available for download from the workflow run artifacts, allowing us to retrieve and commit the CI-generated files to resolve the formatting differences. |
.github/workflows/ci.yml
Outdated
run: cargo generate-lockfile | ||
- name: cargo llvm-cov | ||
run: cargo llvm-cov --locked --all-features --workspace --lcov --output-path lcov.info | ||
- name: Upload generated proto files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lalitb is this relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was added to debug the stack driver proto issue. Will remove it before merge (after downloading the generate proto files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot - The CI for "Upload generated proto files" was only added for debugging purpose. It can be removed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the debug CI step in commit afeae78.
|
||
## vNext | ||
|
||
## [v0.23.0](https://github.com/OutThereLabs/actix-web-opentelemetry/compare/v0.23.0..v0.22.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this link can e removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot - please remove this link - it is not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the link in commit e42cad4. The version heading is now ## v0.23.0
instead of ## [v0.23.0](...)
.
@copilot - Also remove the checked-in proto zip file, it is not required. |
Changed version heading from [v0.23.0](...) to just v0.23.0 to match the changelog style of other packages in the repository. Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
The protoc-29.3-linux-x86_64.zip file was accidentally committed and is not needed in the repository. Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
The step to upload generated proto files was added for debugging purposes and is no longer needed. Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
All crates are published now. |
Update remaining packages to OpenTelemetry Rust v0.31.0
Based on issue #453, the following packages have already been updated to v0.31.0:
Packages updated to v0.31.0:
All packages in the repository have now been updated to use OpenTelemetry Rust v0.31.0 dependencies.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.