Add Contrib Repo Tests workflow on Core PRs #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
a team,
aabmass and
ocelotl
and removed request for
a team
NathanielRN
force-pushed
the
add-contrib-repo-tests-workflow
branch
3 times, most recently
from
f61071d
to
43439ca
Compare
NathanielRN
commented
Nov 4, 2020
| @@ -53,7 +66,7 @@ jobs: | |||
| uses: actions/cache@v2 | |||
| with: | |||
| path: .tox | |||
| key: tox-cache-${{ matrix.python-version }}-${{ matrix.package }}-${{ matrix.os }}-${{ hashFiles('tox.ini', 'dev-requirements.txt') }} | |||
| key: tox-cache-${{ matrix.python-version }}-${{ matrix.package }}-${{ matrix.os }}-${{ hashFiles('tox.ini', 'dev-requirements.txt') }}-core | |||
There was a problem hiding this comment.
Not sure if this is needed...
There was a problem hiding this comment.
I think this is good, should keep the caches smaller
There was a problem hiding this comment.
Not too familiar with the syntax, what is this pointing to? The environment name?
There was a problem hiding this comment.
When I run tox locally, I see a .tox folder gets created, and I see packages being created there.
My guess is that this command caches packages that have the same conditions of python version/matrix/os/files_hash to not have to import the package into it's "tox" environment again. But that's just a guess.
| uses: actions/cache@v2 | ||
| with: | ||
| path: .tox | ||
| key: tox-cache-${{ matrix.tox-environment }}-${{ hashFiles('tox.ini', 'dev-requirements.txt') }}-core |
There was a problem hiding this comment.
Not sure if this is needed...
| uses: actions/cache@v2 | ||
| with: | ||
| path: .tox | ||
| key: tox-cache-${{ matrix.python-version }}-${{ matrix.package }}-${{ matrix.os }}-${{ hashFiles('tox.ini', 'dev-requirements.txt') }}-contrib |
There was a problem hiding this comment.
Not sure if this is needed...
| @@ -76,6 +177,6 @@ jobs: | |||
| uses: actions/cache@v2 | |||
| with: | |||
| path: .tox | |||
| key: tox-cache-${{ matrix.tox-environment }}-${{ hashFiles('tox.ini', 'dev-requirements.txt') }} | |||
| key: tox-cache-${{ matrix.tox-environment }}-${{ hashFiles('tox.ini', 'dev-requirements.txt') }}-contrib | |||
There was a problem hiding this comment.
Not sure if this is needed...
NathanielRN
force-pushed
the
add-contrib-repo-tests-workflow
branch
from
43439ca
to
3eb2fc1
Compare
NathanielRN
force-pushed
the
add-contrib-repo-tests-workflow
branch
4 times, most recently
from
d1f811f
to
bbf12c7
Compare
NathanielRN
commented
Nov 5, 2020
NathanielRN
force-pushed
the
add-contrib-repo-tests-workflow
branch
2 times, most recently
from
26b77cf
to
859d9df
Compare
|
I see this issue happening in a fork: I thought this issue was not happening in the core repo but it seems like it is happening there as well: |
ocelotl
suggested changes
Nov 12, 2020
|
@ocelotl Thanks for the logs! I think you are seeing this problem because you did not clone the Contrib Repo using Please see my logs below, I tried to follow your commands and found that running |
NathanielRN
commented
Nov 12, 2020
ocelotl
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Thanks for this work @NathanielRN, moving the non-core components out of the core repo is a massive task 💪
You probably already have thought about this, having releases of the instrumentation packages should save us from having to clone the contrib repo, right? Is it something we plan on doing?
|
@ocelotl Thanks for your review! 😄 Yes it's exactly like you said :) Once we're in GA and we have releases of all the packages, the Contrib repo packages will all be able to depend on them and install them from Pypi without any repo cloning. That way the progress of the Core Repo & Contrib Repos can be truly independent if we wish, yet we will still have tests to identify discrepancies. |
NathanielRN
force-pushed
the
add-contrib-repo-tests-workflow
branch
from
80559ba
to
a783036
Compare
aabmass
requested changes
Nov 16, 2020
| @@ -53,7 +66,7 @@ jobs: | |||
| uses: actions/cache@v2 | |||
| with: | |||
| path: .tox | |||
| key: tox-cache-${{ matrix.python-version }}-${{ matrix.package }}-${{ matrix.os }}-${{ hashFiles('tox.ini', 'dev-requirements.txt') }} | |||
| key: tox-cache-${{ matrix.python-version }}-${{ matrix.package }}-${{ matrix.os }}-${{ hashFiles('tox.ini', 'dev-requirements.txt') }}-core | |||
There was a problem hiding this comment.
I think this is good, should keep the caches smaller
2 tasks
aabmass
approved these changes
Nov 17, 2020
NathanielRN
force-pushed
the
add-contrib-repo-tests-workflow
branch
from
6d9c6d2
to
bb3605b
Compare
This was referenced Nov 18, 2020
lzchen
approved these changes
Nov 19, 2020
NathanielRN
force-pushed
the
add-contrib-repo-tests-workflow
branch
2 times, most recently
from
2e8258b
to
b833981
Compare
NathanielRN
force-pushed
the
add-contrib-repo-tests-workflow
branch
3 times, most recently
from
0f9890a
to
528b8b0
Compare
NathanielRN
force-pushed
the
add-contrib-repo-tests-workflow
branch
from
528b8b0
to
dd7ba78
Compare
NathanielRN
commented
Nov 19, 2020
| @@ -26,7 +26,6 @@ envlist = | |||
|
|
|||
| ; opentelemetry-example-app | |||
| py3{5,6,7,8}-test-core-example-app | |||
| pypy3-test-core-example-app | |||
There was a problem hiding this comment.
Please note the removal of tests for the Example App on pypy3. The Example App uses grpcio which is not available on pypy packages.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests to check if PRs on the Core repo will break tests from the Contrib Repo.
To test against a particular Contrib Repo PR, change the env variable
CONTRIB_REPO_SHAto prove tests pass. Once they pass, PRs in Core and Contrib can be merged at the same time.This fixes:
tox -e linttox -e docsRelated to #1233
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
New tests added to make sure Core changes don't affect Contrib.
Checklist:
- [ ] Changelogs have been updated- [ ] Documentation has been updated