Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelmetry-example-app should be moved to contrib repo #1391

Closed
mariojonke opened this issue Nov 18, 2020 · 2 comments · Fixed by #1410
Closed

opentelmetry-example-app should be moved to contrib repo #1391

mariojonke opened this issue Nov 18, 2020 · 2 comments · Fixed by #1410
Labels
bug Something isn't working

Comments

@mariojonke
Copy link
Contributor

The opentelemetry_example_app in docs/examples has a setup.cfg with dependencies to opentelemetry-instrumentation-{requets,flask}. These dependencies refer to an already released version 0.15.b0 (i think this should be 0.15b0 instead?).
Since there are tox tests for opentelemtry-example-app they might fail if api and/or sdk in dev version get incompatible with the releassed instrumentation. Also upgrading the dependnecies might be overlooked when releasing a new version since the version string differs.

What is the expected behavior?
Imo opentelemetry_example_app should be moved to the contrib repo since it is mostly requests and flask samples?

@mariojonke mariojonke added the bug Something isn't working label Nov 18, 2020
@NathanielRN
Copy link
Contributor

NathanielRN commented Nov 18, 2020

+1 to this, had an issue with linting it today which made me think that this should really be a Contrib repo item. See #1357

@lzchen
Copy link
Contributor

lzchen commented Nov 23, 2020

I'm wondering do we even need this example app anymore? I'm not sure where we would even put it if we move it to the contrib repo.

@codeboten Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants