Skip to content

refactor(asgi): replace HTTP_SERVER_NAME SpanAttribute with semconv attribute #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rite7sh wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −2
Open

refactor(asgi): replace HTTP_SERVER_NAME SpanAttribute with semconv attribute #4039

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f476206
refactor(asgi): replace HTTP_SERVER_NAME SpanAttribute with semconv a…
rite7sh Dec 17, 2025
9789577
Update instrumentation/opentelemetry-instrumentation-asgi/src/opentel…
rite7sh Dec 19, 2025
a6bd905
Update instrumentation/opentelemetry-instrumentation-asgi/src/opentel…
rite7sh Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...ion/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,9 @@ def client_response_hook(span: Span, scope: Scope, message: dict[str, Any]):
redact_url,
sanitize_method,
)

from opentelemetry.semconv._incubating.attributes.http_attributes import (
HTTP_SERVER_NAME,
)

class ASGIGetter(Getter[dict]):
def get(
Expand Down Expand Up @@ -397,7 +399,7 @@ def collect_request_attributes(
http_host_value_list = asgi_getter.get(scope, "host")
if http_host_value_list:
if _report_old(sem_conv_opt_in_mode):
result[SpanAttributes.HTTP_SERVER_NAME] = ",".join(
result[HTTP_SERVER_NAME] = ",".join(
http_host_value_list
)
http_user_agent = asgi_getter.get(scope, "user-agent")
Expand Down