refactor(asgi): replace HTTP_SERVER_NAME SpanAttribute with semconv attribute #4039
Conversation
|
|
xrmx
left a comment
xrmx
left a comment
There was a problem hiding this comment.
I think there are a lot more users of SpanAttributes in the asgi package
|
|
||
| from asgiref.compatibility import guarantee_single_callable | ||
|
|
||
|
|
| if http_host_value_list: | ||
| if _report_old(sem_conv_opt_in_mode): | ||
| result[SpanAttributes.HTTP_SERVER_NAME] = ",".join( | ||
| result[HTTP_SERVER_NAME] = ",".join( |
There was a problem hiding this comment.
| result[HTTP_SERVER_NAME] = ",".join( | |
| result[HTTP_SERVER_NAME] = ",".join( |
Looks like you haven't setup precommit as written in CONTRIBUTING
There was a problem hiding this comment.
Thanks for pointing that out.
I intentionally limited the scope of this PR to the HTTP_SERVER_NAME usage to keep the change small and aligned with the guidance in #3475, and to avoid changing telemetry output.
I’ve also set up and run the pre-commit hooks locally as described in CONTRIBUTING, and amended the commit accordingly.
Happy to follow up with additional SpanAttributes replacements in a separate PR if that would be useful.
2 participants
Refs #3475
Type of change
How Has This Been Tested?
This change updates a semantic convention attribute constant without modifying
runtime behavior. Local test execution on Windows is limited by environment
constraints; CI will validate the change.
Does This PR Require a Core Repo Change?
Checklist: