Configurable Middleware Position for Django Instrumentation #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontrib into anshul-fix-1781-alt
This was referenced Oct 17, 2024
lzchen
reviewed
Oct 24, 2024
lzchen
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1781
This PR has addressed all the comments present in #2834 and #1903 so far. Raising it separately to accelerate merging of this code.
I had to not use commits 896f6f5 and ca9e744 from #2834 PR as those commits author has not signed CLA or has some CLA problem.
cc: @xrmx @lzchen
Description
Feature to add middleware at specific location. Added keyword argument middleware_position which one can set to the number of middleware they want to add before otel middleware to start instrumentation.
Fixes #1781
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.