Adding Custom Middleware Position for Django Instrumentation #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Puneet140500
changed the title
|
@Puneet140500 You need to fix the history committing only from accounts that covered by the CLA |
xrmx
reviewed
Aug 30, 2024
| middleware_position, | ||
| len(settings_middleware), | ||
| ) | ||
| middleware_position = len(settings_middleware) |
There was a problem hiding this comment.
Shouldn't the default be 0 as it was before?
lzchen
reviewed
Sep 4, 2024
| @@ -388,10 +388,25 @@ def _instrument(self, **kwargs): | |||
|
|
|||
| is_sql_commentor_enabled = kwargs.pop("is_sql_commentor_enabled", None) | |||
|
|
|||
| otel_position = environ.get("OTEL_PYTHON_DJANGO_MIDDLEWARE_POSITION") | |||
| middleware_position = int(otel_position) if otel_position is not None else kwargs.pop("middleware_position", 0) | |||
This was referenced Sep 12, 2024
| @@ -378,6 +378,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ([#1879](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1879)) | |||
| - Add optional distro and configurator selection for auto-instrumentation | |||
| ([#1823](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1823)) | |||
| - Add option to add Opentelemetry middleware at specific position in middleware chain | |||
| ([#1903]https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1903) | |||
There was a problem hiding this comment.
This should be updated with the new PR number?
|
@Puneet140500 , I've made some changes and raised a PR to your branch itself. If they make sense, you can go ahead and merge. I'm hoping for this PR to go live soon as we have a utility in my codebase for it :) |
This was referenced Oct 14, 2024
|
Closing in favor of #2912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1781