Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove label mapping for service.instance.id #3497

Merged
merged 14 commits into from
Dec 10, 2024
Merged

Remove label mapping for service.instance.id #3497

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
aa3e781
Remove the mapping of `app.kubernetes.io/instance` to `service.instan…
zeitlinger Nov 27, 2024
cd5c44e
Remove the mapping of `app.kubernetes.io/instance` to `service.instan…
zeitlinger Nov 27, 2024
bca76c6
Remove the mapping of `app.kubernetes.io/instance` to `service.instan…
zeitlinger Nov 27, 2024
8420019
Remove the mapping of `app.kubernetes.io/instance` to `service.instan…
zeitlinger Nov 27, 2024
ef24a5f
Remove the mapping of `app.kubernetes.io/instance` to `service.instan…
zeitlinger Nov 27, 2024
1c64af9
Remove the mapping of `app.kubernetes.io/instance` to `service.instan…
zeitlinger Nov 27, 2024
68a1b9f
Update .chloggen/service-instanc-id-mapping.yaml
zeitlinger Nov 28, 2024
d248262
Update .chloggen/service-instanc-id-mapping.yaml
zeitlinger Nov 28, 2024
872f482
add docs
zeitlinger Nov 28, 2024
119040b
Merge branch 'main' into service-instanc-id-mapping
zeitlinger Dec 10, 2024
96c8a06
Update README.md
zeitlinger Dec 10, 2024
becbfeb
Apply suggestions from code review
zeitlinger Dec 10, 2024
0c4863e
add docs
zeitlinger Dec 10, 2024
db09955
add docs
zeitlinger Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update .chloggen/service-instanc-id-mapping.yaml 
Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
  • Loading branch information
@zeitlinger @jaronoff97
zeitlinger and jaronoff97 authored Nov 28, 2024
commit 68a1b9f975fa9b1f4caea29165f656815877af0a
2 changes: 1 addition & 1 deletion .chloggen/service-instanc-id-mapping.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ issues: [3495]
subtext: |
Technically, this is a breaking change, but we regard it as a bug fix because the previous behavior was incorrect.

In you did have multiple containers and use `app.kubernetes.io/instance` to set the `service.instance.id`,
if you did have multiple container instrumentation and use `app.kubernetes.io/instance` to set the `service.instance.id`,
you will now see multiple instances in the UI - which is the correct behavior.

You can still use the attribute `resource.opentelemetry.io/service.instance.id` to set the `service.instance.id`,
Expand Down
Loading