Remove label mapping for service.instance.id
#3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce.id`, because multiple containers should never share the same `service.instance.id`
…ce.id`, because multiple containers should never share the same `service.instance.id`
…ce.id`, because multiple containers should never share the same `service.instance.id`
…ce.id`, because multiple containers should never share the same `service.instance.id`
…ce.id`, because multiple containers should never share the same `service.instance.id`
jaronoff97
reviewed
Nov 27, 2024
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
There was a problem hiding this comment.
@zeitlinger could you call out that this is a bug fix and also technically a breaking change? Include some of the details here about why this is a bug fix specifically and not a breaking change
…ce.id`, because multiple containers
should never share the same `service.instance.id`
jaronoff97
reviewed
Nov 27, 2024
Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
zeitlinger
commented
Nov 28, 2024
|
@jaronoff97 please check again |
|
@zeitlinger i want to think a bit more about this after some of the user feedback in the thread in slack. Maybe we should discuss this at our SIG meeting this week? |
|
@jaronoff97 as discussed in the meeting last week, this should be good to merge. |
Co-authored-by: Cyrille Le Clerc <cyrille@cyrilleleclerc.com>
Co-authored-by: Cyrille Le Clerc <cyrille@cyrilleleclerc.com>
swiatekm
approved these changes
Dec 10, 2024
jaronoff97
approved these changes
Dec 10, 2024
|
@zeitlinger @cyrille-leclerc Thank you for your contributions here! 🙇 |
|
|
||
|
|
||
| - `pod.annotation[resource.opentelemetry.io/service.instance.id]` | ||
| - `if (config[useLabelsForResourceAttributes]) pod.label[app.kubernetes.io/instance]` |
There was a problem hiding this comment.
@zeitlinger shouldn't we remove this line from the docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useLabelsForResourceAttributes#3495Testing: updated existing
Documentation: updated existing