-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate the creation of the permissions needed by k8sattributes. #2396
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action) | ||
component: operator | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Automate the creation of the permissions needed by the k8sattributes processor | ||
|
||
# One or more tracking issues related to the change | ||
issues: [2395] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: |
109 changes: 109 additions & 0 deletions
109
internal/manifests/collector/parser/processor/processor_k8sattributes.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package processor | ||
|
||
import ( | ||
"fmt" | ||
"strings" | ||
|
||
"github.com/go-logr/logr" | ||
rbacv1 "k8s.io/api/rbac/v1" | ||
) | ||
|
||
var _ ProcessorParser = &K8sAttributesParser{} | ||
|
||
const ( | ||
parserNameK8sAttributes = "__k8sattributes" | ||
) | ||
|
||
// PrometheusExporterParser parses the configuration for k8sattributes processor. | ||
type K8sAttributesParser struct { | ||
config map[interface{}]interface{} | ||
logger logr.Logger | ||
name string | ||
} | ||
|
||
// NewK8sAttributesParser builds a new parser k8sattributes processor. | ||
func NewK8sAttributesParser(logger logr.Logger, name string, config map[interface{}]interface{}) ProcessorParser { | ||
return &K8sAttributesParser{ | ||
logger: logger, | ||
name: name, | ||
config: config, | ||
} | ||
} | ||
|
||
// ParserName returns the name of this parser. | ||
func (o *K8sAttributesParser) ParserName() string { | ||
return parserNameK8sAttributes | ||
} | ||
|
||
func (o *K8sAttributesParser) GetRBACRules() []rbacv1.PolicyRule { | ||
var prs []rbacv1.PolicyRule | ||
|
||
extractCfg, ok := o.config["extract"] | ||
if !ok { | ||
return prs | ||
} | ||
|
||
metadataCfg, ok := extractCfg.(map[interface{}]interface{})["metadata"] | ||
if !ok { | ||
return prs | ||
} | ||
|
||
metadata, ok := metadataCfg.([]interface{}) | ||
if !ok { | ||
return prs | ||
} | ||
|
||
// This one needs to be added always | ||
policy := rbacv1.PolicyRule{ | ||
APIGroups: []string{""}, | ||
Resources: []string{"pods", "namespaces"}, | ||
Verbs: []string{"get", "watch", "list"}, | ||
} | ||
prs = append(prs, policy) | ||
|
||
for _, m := range metadata { | ||
metadataField := fmt.Sprint(m) | ||
if metadataField == "k8s.deployment.uid" || metadataField == "k8s.deployment.name" { | ||
prs = append(prs, | ||
rbacv1.PolicyRule{ | ||
APIGroups: []string{"apps"}, | ||
Resources: []string{"replicasets"}, | ||
Verbs: []string{"get", "watch", "list"}, | ||
}, | ||
rbacv1.PolicyRule{ | ||
APIGroups: []string{"extensions"}, | ||
Resources: []string{"replicasets"}, | ||
Verbs: []string{"get", "watch", "list"}, | ||
}, | ||
) | ||
} else if strings.Contains(metadataField, "k8s.node") { | ||
prs = append(prs, | ||
rbacv1.PolicyRule{ | ||
APIGroups: []string{""}, | ||
Resources: []string{"nodes"}, | ||
Verbs: []string{"get", "watch", "list"}, | ||
}, | ||
) | ||
} | ||
} | ||
|
||
return prs | ||
} | ||
|
||
func init() { | ||
Register("k8sattributes", NewK8sAttributesParser) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this situation still needs addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I didn´t see that.