-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate the creation of the permissions needed by k8sattributes. #2396
Conversation
…cessor Signed-off-by: Israel Blancas <iblancasa@gmail.com>
return parserNameK8sAttributes | ||
} | ||
|
||
func (o *K8sAttributesParser) GetRBACRules() []rbacv1.PolicyRule { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When extracting metadatas from node, the processor needs get, watch and list permissions for nodes resources.
I believe this situation still needs addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I didn´t see that.
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
With the latest helm charts I am still facing this issue. I've tried creating explicit RBAC roles but still no luck. The collector keeps failing with this error: "E0315 20:53:15.417043 1 reflector.go:147] k8s.io/client-go@v0.29.1/tools/cache/reflector.go:229: Failed to watch *v1.Pod: failed to list *v1.Pod: pods is forbidden: User "system:serviceaccount:default:otel-collector-collector" cannot list resource "pods" in API group "" at the cluster scope". I could see only the 'k8s.pod.ip' tag alone in the traces but not other k8s metadata. Could you please help me here and let me know if I am missing something, thank you. Following are my config files, FYI I am using mode as Deployment. Kustomisation file apiVersion: kustomize.config.k8s.io/v1beta1
Following is my collector-config.yaml file: apiVersion: opentelemetry.io/v1alpha1
|
#2525 removed the permissions the operator needs to create the RBAC for the processors. You need to add them. |
Thanks for confirming @iblancasa, will create them and see if that solves my problem. |
…en-telemetry#2396) * Automate the creation of the RBAC resources for the k8sattributes processor Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Add missing permission Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Add missing changelog Signed-off-by: Israel Blancas <iblancasa@gmail.com> --------- Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Description:
Continuation of #2394.
Link to tracking Issue: #2395