fix(sdk-trace-base): ensure attribute value length limit is enforced on span creation #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
added
pkg:sdk-trace-base
bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4417 +/- ##
=========================================
+ Coverage 0 92.24% +92.24%
=========================================
Files 0 333 +333
Lines 0 9451 +9451
Branches 0 2008 +2008
=========================================
+ Hits 0 8718 +8718
- Misses 0 733 +733
|
legendecas
approved these changes
Jan 15, 2024
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…on span creation (open-telemetry#4417) * fix(sdk-trace-base): ensure attribute value length limit is enforced on span creation * fix(changelog): add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The attribute value length limit was not enforced when a span was created with attributes
Fixes #4416
Short description of the changes
Set the length limit before setting the attributes.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?