Span attributes value length limit ignored for attributes passed to the Span constructor

[Bataran]

What happened?

Steps to Reproduce

Install the packages defined in the package.json:
npm i

Run the sample app with script:
npm run startWithEnv

Expected Result

Span has 2 attributes attr1 and attr2 with truncated values "myval"

Actual Result

Span has attr1 attribute with non truncated value "myvalue" and attr2 attribute with truncated value "myval.

Additional Details

Attributes passed to the Span constructor are not truncated with the limit defined by OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT while the attributes passed to span.setAttributes() are. The issue seems to be introduced with the 1.19.0 version of @opentelemetry/sdk-trace-base

OpenTelemetry Setup Code

// bug.js
const opentelemetry = require('@opentelemetry/api');
const { BasicTracerProvider } = require('@opentelemetry/sdk-trace-base');

new BasicTracerProvider().register();

const span = opentelemetry.trace
	.getTracer('default')
	.startSpan('foo', {
		attributes: {
			attr1: "myvalue"
		}
	});

span.setAttribute('attr2', 'myvalue');

// the span has attr1 with non-truncated value "myvalue"
// and attr2 with truncated value "myval"
// when the script is run with OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT=5
console.log(`span.attributes.attr1 => ${span.attributes.attr1}`)
console.log(`span.attributes.attr2 => ${span.attributes.attr2}`)

span.end();

package.json

{
  "name": "bug-sample",
  "version": "0.0.1",
  "description": "bug sample",
  "main": "bug.js",
  "scripts": {
    "startWithEnv": "env OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT=5 node bug.js"
  },
  "dependencies": {
    "@opentelemetry/api": "1.7.0",
    "@opentelemetry/sdk-trace-base": "1.19.0"
  }
}

Relevant log output

> but-sample@0.0.1 startWithEnv
> env OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT=5 node bug.js

span.attributes.attr1 => myvalue
span.attributes.attr2 => myval

[pichlermarc]

Yep, looks like that's introduced with 1.19.0. The attributes are set before the limit is set in the span implementation. I'll assign this to myself.

[pichlermarc]

Opened #4417 to take care of this, thanks for the report @Bataran 🙂