Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add secureConnectionStart to https only #3879

Merged
merged 6 commits into from
Jul 5, 2023
Merged

fix: add secureConnectionStart to https only #3879

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40be61a
fix: add secureConnectionStart to https only
Abinet18 Jun 9, 2023
c83aaf9
fix: fix test
Abinet18 Jun 9, 2023
611cc4d
fix: typo and test fixes
Abinet18 Jun 9, 2023
29f29a7
Update packages/opentelemetry-sdk-trace-web/src/utils.ts
Abinet18 Jun 13, 2023
03abf7a
fix: fix xhr and fetch tests
Abinet18 Jun 14, 2023
1026595
Merge branch 'main' into fix/secure-conn-start-for-https-only
pichlermarc Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/opentelemetry-sdk-trace-web/src/utils.ts 
Co-authored-by: t2t2 <taavot@gmail.com>
  • Loading branch information
@Abinet18 @t2t2
Abinet18 and t2t2 committed Jun 13, 2023
commit 29f29a74d680171fcbd6e17ef71b783a15581eb5
2 changes: 1 addition & 1 deletion packages/opentelemetry-sdk-trace-web/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export function addSpanNetworkEvents(
addSpanNetworkEvent(span, PTN.CONNECT_START, resource);
if (
hasKey(resource as PerformanceResourceTiming, 'name') &&
getProtocol((resource as PerformanceResourceTiming)['name']) === 'https:'
(resource as PerformanceResourceTiming)['name'].startsWith('https:')
Abinet18 marked this conversation as resolved.
Show resolved Hide resolved
) {
addSpanNetworkEvent(span, PTN.SECURE_CONNECTION_START, resource);
}
Expand Down