-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add secureConnectionStart to https only #3879
Merged
pichlermarc
merged 6 commits into
open-telemetry:main
from
Abinet18:fix/secure-conn-start-for-https-only
Jul 5, 2023
Merged
fix: add secureConnectionStart to https only #3879
pichlermarc
merged 6 commits into
open-telemetry:main
from
Abinet18:fix/secure-conn-start-for-https-only
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3879 +/- ##
==========================================
- Coverage 93.13% 92.89% -0.24%
==========================================
Files 298 297 -1
Lines 8868 8839 -29
Branches 1826 1817 -9
==========================================
- Hits 8259 8211 -48
- Misses 609 628 +19
|
MSNev
reviewed
Jun 12, 2023
t2t2
reviewed
Jun 13, 2023
Co-authored-by: t2t2 <taavot@gmail.com>
Abinet18
force-pushed
the
fix/secure-conn-start-for-https-only
branch
2 times, most recently
from
June 14, 2023 20:12
ea985aa
to
3d7104e
Compare
Abinet18
force-pushed
the
fix/secure-conn-start-for-https-only
branch
from
June 14, 2023 20:13
3d7104e
to
03abf7a
Compare
MSNev
reviewed
Jun 14, 2023
MSNev
approved these changes
Jun 14, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Avoid adding secure connection start span event for insecure connection
Fixes # (issue)
#3848
How Has This Been Tested?
Tested through document load instrumentation and checking the resulting span events
Checklist: