Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add secureConnectionStart to https only #3879

Merged

Conversation

Abinet18
Copy link
Contributor

@Abinet18 Abinet18 commented Jun 9, 2023

Which problem is this PR solving?

Avoid adding secure connection start span event for insecure connection

Fixes # (issue)
#3848

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested through document load instrumentation and checking the resulting span events

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Abinet18 Abinet18 requested a review from a team June 9, 2023 18:02
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #3879 (e54597e) into main (dccd906) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

❗ Current head e54597e differs from pull request most recent head 1026595. Consider uploading reports for the commit 1026595 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3879      +/-   ##
==========================================
- Coverage   93.13%   92.89%   -0.24%     
==========================================
  Files         298      297       -1     
  Lines        8868     8839      -29     
  Branches     1826     1817       -9     
==========================================
- Hits         8259     8211      -48     
- Misses        609      628      +19     
Impacted Files Coverage Δ
packages/opentelemetry-sdk-trace-web/src/utils.ts 94.67% <100.00%> (+0.09%) ⬆️

... and 19 files with indirect coverage changes

Co-authored-by: t2t2 <taavot@gmail.com>
@Abinet18 Abinet18 force-pushed the fix/secure-conn-start-for-https-only branch 2 times, most recently from ea985aa to 3d7104e Compare June 14, 2023 20:12
@Abinet18 Abinet18 force-pushed the fix/secure-conn-start-for-https-only branch from 3d7104e to 03abf7a Compare June 14, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants