Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instrumentation-grpc): add 'grpc' deprecation notice postinstall script #3833

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented May 24, 2023

Which problem is this PR solving?

We currently have no proper way to notify users that the 'grpc' package instrumentation code is being removed from the @opentelemetry/instrumentation-grpc package. As discussed in the SIG meeting last week, since the package is not released as stable yet, increasing semver major is not an option.

Please feel free to suggest any changes to wording of the changelog/message.

Related #3780, #3807

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • None of the above?

How Has This Been Tested?

  • Ran postinstall script locally

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #3833 (4fe01e9) into main (0c12777) will decrease coverage by 1.23%.
The diff coverage is n/a.

❗ Current head 4fe01e9 differs from pull request most recent head 32d1195. Consider uploading reports for the commit 32d1195 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3833      +/-   ##
==========================================
- Coverage   92.95%   91.73%   -1.23%     
==========================================
  Files         297      169     -128     
  Lines        9060     4672    -4388     
  Branches     1848      927     -921     
==========================================
- Hits         8422     4286    -4136     
+ Misses        638      386     -252     

see 137 files with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review May 25, 2023 05:47
@pichlermarc pichlermarc requested a review from a team May 25, 2023 05:47
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
@dyladan dyladan added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label May 25, 2023
Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a non-blocking suggestion for adding color to make it pop more, otherwise looks good to me.

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hectorhdzg

This comment was marked as duplicate.

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! definitely grabs your attention.

instr-grpc-warning-purple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants