-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for package grpc
in instrumentation and examples
#3780
Comments
This seems particularly appropriate since there's currently a chicken-egg problem in that @opentelemetry/exporter-metrics-grpc itself loads the grpc library which happens before instrumentation is installed, so you always get the warning that you are trying to instrument a library which has already been loaded and so the instrumentation won't work. |
I think the problem will still exist if we keep the package |
We're actually already using |
I'm not sure what the original reason for combining the instrumentations was, but I'd be all for de-supporting instrumentations for deprecated libraries. WDYT @open-telemetry/javascript-approvers? |
istrumentation for grpc was created quite some time before instrumentation for grpc-js was added. They share quite some code. An alternative would have been to create a third package grpc instrumentation base but well that ship has sailed. As instrumentation is experimental it's likely ok to remove support for grpc. We removed support for older node.js versions also without moving to 2.0 therefore I think it should be fine to remove grpc in the next minor release. |
As the package
grpc
has been deprecated for whole 2 years, everyone should avoid using the package, or at least, in new projects.Also, the
node-gyp
part of its installation has never been successful on Windows machines (with the latestnode.js
runtime), which is annoying for Windows developers like me. I can do the development in WSL2 but it is still a problem if I need to do the web stuff.So I suggest we drop the support of the package in
instrumentation-grpc
and remove thegrpc
example.The text was updated successfully, but these errors were encountered: