Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add selenium tests on webworker #2659

Closed

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Add regression testing on web workers for #2465 and open-telemetry/opentelemetry-js-api#126.

Type of change

  • Testing facilities

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #2659 (975a463) into main (6b94e26) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 975a463 differs from pull request most recent head 0dad59f. Consider uploading reports for the commit 0dad59f to get more accurate results

@@            Coverage Diff             @@
##             main    #2659      +/-   ##
==========================================
- Coverage   93.03%   93.03%   -0.01%     
==========================================
  Files         155      155              
  Lines        5373     5368       -5     
  Branches     1133     1131       -2     
==========================================
- Hits         4999     4994       -5     
  Misses        374      374              
Impacted Files Coverage Δ
packages/opentelemetry-sdk-trace-web/src/utils.ts 95.00% <100.00%> (ø)
...metry-sdk-metrics-base/src/aggregator/Histogram.ts 97.91% <0.00%> (-0.09%) ⬇️
...entelemetry-sdk-metrics-base/src/aggregator/Sum.ts 100.00% <0.00%> (ø)
...ntelemetry-sdk-metrics-base/src/aggregator/Drop.ts 100.00% <0.00%> (ø)
...telemetry-sdk-metrics-base/src/aggregator/types.ts 100.00% <0.00%> (ø)
...metry-sdk-metrics-base/src/aggregator/LastValue.ts 100.00% <0.00%> (ø)
...-metrics-base/src/state/TemporalMetricProcessor.ts 97.91% <0.00%> (+0.04%) ⬆️

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@legendecas
Copy link
Member Author

We need a version release on @opentelemetry/sdk-trace-web to get the experimental instrumentation fetch works in the test.

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 16, 2022
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

This PR was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant