-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger incoming headers format should be able to accept url encoded value #734
Comments
I wonder if we should be supporting the jaeger format at all. We allow users to plug in any format they want, so having it be an external project should be no problem. I think it might be worthwhile to find a maintainer and a permanent home for the jaeger format outside of the opentelemetry repo. cc @mayurkale22 |
@dyladan i can fix it and probably you are right it kinda belong to another project |
I agree with @dyladan, IMO we can ask the author of the Jaeger format to host the module and if they want we can add a link in top README. WDYT? |
On another hand in opentelemetry-js packages we have jaeger exporter that works with jaeger too and i think this format not in active development so there will be not so many troubles to support it |
I think it's fine for now, but we may want to move it later |
Practically all jaeger trace headers in http encoded via UTF-8
so trace like:
ac1f3dc3c2c0b06e:5ac292c4a11a163e:c086aaa825821068:1
become:
ac1f3dc3c2c0b06e%3A5ac292c4a11a163e%3Ac086aaa825821068%3A1
currentrly opentelemetry-propagator-jaeger unable to extract this header
The text was updated successfully, but these errors were encountered: