Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger incoming headers format should be able to accept url encoded value #734

Closed
DotSpy opened this issue Jan 27, 2020 · 5 comments · Fixed by #735
Closed

Jaeger incoming headers format should be able to accept url encoded value #734

DotSpy opened this issue Jan 27, 2020 · 5 comments · Fixed by #735
Assignees

Comments

@DotSpy
Copy link
Member

DotSpy commented Jan 27, 2020

Practically all jaeger trace headers in http encoded via UTF-8
so trace like:
ac1f3dc3c2c0b06e:5ac292c4a11a163e:c086aaa825821068:1
become:
ac1f3dc3c2c0b06e%3A5ac292c4a11a163e%3Ac086aaa825821068%3A1
currentrly opentelemetry-propagator-jaeger unable to extract this header

@dyladan
Copy link
Member

dyladan commented Jan 27, 2020

I wonder if we should be supporting the jaeger format at all. We allow users to plug in any format they want, so having it be an external project should be no problem. I think it might be worthwhile to find a maintainer and a permanent home for the jaeger format outside of the opentelemetry repo. cc @mayurkale22

@DotSpy
Copy link
Member Author

DotSpy commented Jan 27, 2020

@dyladan i can fix it and probably you are right it kinda belong to another project

@mayurkale22
Copy link
Member

I agree with @dyladan, IMO we can ask the author of the Jaeger format to host the module and if they want we can add a link in top README. WDYT?

@DotSpy
Copy link
Member Author

DotSpy commented Jan 29, 2020

On another hand in opentelemetry-js packages we have jaeger exporter that works with jaeger too and i think this format not in active development so there will be not so many troubles to support it

@dyladan
Copy link
Member

dyladan commented Jan 29, 2020

I think it's fine for now, but we may want to move it later

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants