-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: decode jaeger header #735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DotSpy
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
January 27, 2020 15:33
dyladan
reviewed
Jan 27, 2020
packages/opentelemetry-propagator-jaeger/src/JaegerHttpTraceFormat.ts
Outdated
Show resolved
Hide resolved
dyladan
reviewed
Jan 27, 2020
packages/opentelemetry-propagator-jaeger/src/JaegerHttpTraceFormat.ts
Outdated
Show resolved
Hide resolved
dyladan
approved these changes
Jan 27, 2020
obecny
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dyladan
approved these changes
Jan 28, 2020
mayurkale22
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
+ Coverage 92.62% 92.64% +0.02%
==========================================
Files 227 227
Lines 10330 10305 -25
Branches 937 931 -6
==========================================
- Hits 9568 9547 -21
+ Misses 762 758 -4
|
6 tasks
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* feat: decode jaeger header * fix: gts fix * fix: use const instead of variables * fix: use const for headers Co-authored-by: Uladzislau Kiva <vladislav.kiva@moneyman.ru> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes