Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint-config-airbnb-base to v15 #735

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Nov 12, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-config-airbnb-base 14.2.1 -> 15.0.0 age adoption passing confidence

Release Notes

airbnb/javascript

v15.0.0

Compare Source


Configuration

📅 Schedule: "before 3am on Friday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team November 12, 2021 00:07
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Nov 12, 2021
@renovate-bot renovate-bot force-pushed the renovate/eslint-config-airbnb-base-15.x branch from ca8a676 to adf7129 Compare January 14, 2022 13:34
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #735 (9ea75c8) into main (3ee472d) will decrease coverage by 0.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
- Coverage   95.29%   94.71%   -0.59%     
==========================================
  Files          10       16       +6     
  Lines         701      813     +112     
  Branches      142      162      +20     
==========================================
+ Hits          668      770     +102     
- Misses         33       43      +10     
Impacted Files Coverage Δ
...ction/src/contentScript/InstrumentationInjector.ts 100.00% <0.00%> (ø)
...rc/background/ProgrammaticContentScriptInjector.ts 100.00% <0.00%> (ø)
...njection/src/instrumentation/WebInstrumentation.ts 97.22% <0.00%> (ø)
...metry-browser-extension-autoinjection/src/types.ts 90.32% <0.00%> (ø)
...er-extension-autoinjection/src/background/index.ts 0.00% <0.00%> (ø)
...extension-autoinjection/src/contentScript/index.ts 0.00% <0.00%> (ø)

@blumamir
Copy link
Member

@open-telemetry/javascript-maintainers

eslint-config-airbnb-base doesn't seem to have a changlog, but CI is green including lint.
Should we merge it or close it?

@YanivD
Copy link
Member

YanivD commented Jan 31, 2022

I think it's safe to merge it.

Change log: 15.0.0 / 2021-11-08

@renovate-bot renovate-bot force-pushed the renovate/eslint-config-airbnb-base-15.x branch from dbbe7e6 to 9ea75c8 Compare January 31, 2022 13:40
@dyladan
Copy link
Member

dyladan commented Jan 31, 2022

Yes a successful lint is enough because we lint all packages unlike tests which only do changed packages.

@dyladan dyladan merged commit f7f86f6 into open-telemetry:main Jan 31, 2022
@renovate-bot renovate-bot deleted the renovate/eslint-config-airbnb-base-15.x branch January 31, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants